Fix duplicate symbols for functions in cpp2util.h #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp2::report_and_terminate, cpp2::to_string, and cpp2::fopen duplicate symbols and compilation fails on linking. This change makes them inline.
|
That fixes it: https://godbolt.org/z/aWvc57G8W. On #42, you mentioned
Perhaps you could use Compiler Explorer to investigate that. |
|
Looks good, thanks. |
Azmah-Bad
pushed a commit
to Azmah-Bad/cppfront
that referenced
this pull request
Feb 24, 2023
…symbols Fix duplicate symbols for functions in cpp2util.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp2::report_and_terminate,cpp2::to_string, andcpp2::fopenduplicate symbols and compilation fails on linking.This change makes them
inline.closes #42