Skip to content

fix(parse): permit unbraced initializer after requires #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented May 30, 2023

Resolves #423.

Testing summary.
100% tests passed, 0 tests failed out of 508

Total Test time (real) = 123.03 sec
Acknowledgements.

@JohelEGP
Copy link
Contributor Author

JohelEGP commented May 31, 2023

I think the test happens to work, despite #323,
because the definition overloads with the declaration.
So actually not emitting the requires on the declaration
wouldn't be a fix even for GCC 10.
IOW, GCC 10 can't support order independence for a declaration with a requires clause.

@hsutter
Copy link
Owner

hsutter commented Jul 9, 2023

Thanks! Looks good, nice fix.

Re requires and GCC 10: I'm going to move the baseline GCC from 10 up to 11 to rely on the requires bugfix in GCC 11 (and test with 13, which you've already started creating a regression test directory for). Enabling that requires emission on the declaration will be another update...

@hsutter hsutter merged commit 2a7c583 into hsutter:main Jul 9, 2023
@JohelEGP JohelEGP deleted the requires-clause branch July 9, 2023 01:03
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
* fix(parse): permit unbraced initializer after requires

* test: add `test-results/gcc-13`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't mix requires clause with simple function body
2 participants