Skip to content

Improve/update tests #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Improve/update tests #590

merged 1 commit into from
Aug 31, 2023

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented Aug 14, 2023

Minor changes/fixes in tests that makes automatic testing a bit easier:

Test results as indicated in a PR into my regression test CI branch. Some tests are skipped due to compiler issues:

  • Ubuntu - none, all used versions of clang and gcc work just fine for all tests; GitHub Ubuntu runners do not have GCC 13 installed (current LTS Ubuntu doesn't provide it), but the available version 12 works well using regression-tests/gcc-13/*.
  • macOS - missing support for parts of C++20 in Apple's clang 14.
  • Windows - the experimental std modules MSVC package is not installed in on GitHubs's Windows runners.
    More details can e found in the outputs of the CI runs.

@JohelEGP
Copy link
Contributor

Why were they ever different in the first place?
I think it may be because the test scripts do not guarantee the order the tests are run in.
There are two tests that write this file.

@JohelEGP
Copy link
Contributor

  • Windows - the experimental std modules MSVC package is not installed in on GitHubs's Windows runners.

See also modern-cmake/cppfront#83.

@jarzec
Copy link
Contributor Author

jarzec commented Aug 14, 2023

Concerning Freddy currently my testing script does not check the content of this file (this could be easily added). I just noticed that the content of gcc-13 was different from the others. I checked why and proposed a "fix".

Concerning the MSVC issue thanks for the link I will have a look at it for my GitHub workflow, but I think it does not impact this PR.

@@ -11,7 +11,7 @@ myclass: explicit from string
myclass: default
data: 504, more: 3.141590
myclass: from int and string
data: 77, more: hair plugh
data: 77, more: hair1 plugh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently causing a failure on macOS.

@@ -20,5 +21,5 @@ main: (args) -> int = {
test(z);

for args do (arg)
std::cout << arg << "\n";
std::cout << std::filesystem::path(arg).filename() << "\n";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit of a hack, but avoids issues like different relative paths or absolute path used for execution.

@jarzec jarzec force-pushed the update-improve-tests branch from 49ff3f1 to 7cfd91a Compare August 19, 2023 21:58
@jarzec jarzec force-pushed the update-improve-tests branch from 7cfd91a to 31819d4 Compare August 19, 2023 22:28
@hsutter
Copy link
Owner

hsutter commented Aug 31, 2023

Thanks!

@hsutter hsutter merged commit ce8f8bc into hsutter:main Aug 31, 2023
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants