-
Notifications
You must be signed in to change notification settings - Fork 262
Improve/update tests #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/update tests #590
Conversation
Why were they ever different in the first place? |
See also modern-cmake/cppfront#83. |
Concerning Freddy currently my testing script does not check the content of this file (this could be easily added). I just noticed that the content of gcc-13 was different from the others. I checked why and proposed a "fix". Concerning the MSVC issue thanks for the link I will have a look at it for my GitHub workflow, but I think it does not impact this PR. |
@@ -11,7 +11,7 @@ myclass: explicit from string | |||
myclass: default | |||
data: 504, more: 3.141590 | |||
myclass: from int and string | |||
data: 77, more: hair plugh | |||
data: 77, more: hair1 plugh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently causing a failure on macOS.
@@ -20,5 +21,5 @@ main: (args) -> int = { | |||
test(z); | |||
|
|||
for args do (arg) | |||
std::cout << arg << "\n"; | |||
std::cout << std::filesystem::path(arg).filename() << "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a hack, but avoids issues like different relative paths or absolute path used for execution.
49ff3f1
to
7cfd91a
Compare
7cfd91a
to
31819d4
Compare
Thanks! |
Minor changes/fixes in tests that makes automatic testing a bit easier:
mixed-fixed-type-aliases.cpp2 - was updated not to depend on the exact command executing the test binary.
regression-tests/pure2-stdio-with-raii.cpp2 - was updated to make the content of the (commtied) xzyyz file the same for all tests that write into that file. regression-tests/test-results/gcc-13/xyzzy was updated accordingly.
pure2-types-basics.cpp.execution - was not up to date,
Test results as indicated in a PR into my regression test CI branch. Some tests are skipped due to compiler issues:
regression-tests/gcc-13/*
.More details can e found in the outputs of the CI runs.