Skip to content

refactor(parse): cache "expression list is a fold expression" #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023
Merged

refactor(parse): cache "expression list is a fold expression" #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion source/parse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ struct primary_expression_node
std::unique_ptr<inspect_expression_node>,
std::unique_ptr<literal_node>
> expr;
// Cache to work around <https://github.com/llvm/llvm-project/issues/73336>.
bool expression_list_is_fold_expression = false;


// API
Expand Down Expand Up @@ -1556,7 +1558,7 @@ auto primary_expression_node::is_fold_expression() const
break;case identifier:
return *std::get<identifier>(expr) == "...";
break;case expression_list:
return std::get<expression_list>(expr)->is_fold_expression();
return expression_list_is_fold_expression;
break;case id_expression:
return std::get<id_expression>(expr)->is_fold_expression();
break;default: ; // the others can't contain folds
Expand Down Expand Up @@ -5422,6 +5424,7 @@ class parser
) {
expr_list->inside_initializer = false;
}
n->expression_list_is_fold_expression = expr_list->is_fold_expression();
n->expr = std::move(expr_list);
return n;
}
Expand Down