Skip to content

MSVC regression-test job in CI now uses -include-std to workaround a problem with support for C++ modules #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

bluetarpmedia
Copy link
Contributor

Fixes (or works around) #943

Note that this fix has exposed some MSVC pure2 tests which were silently failing:

  • pure2-main-args.cpp.execution
  • pure2-repeated-call.cpp.execution
  • pure2-union.cpp.execution
  • pure2-variadics.cpp.execution

I updated all of them except pure2-main-args.cpp.execution since I wasn't sure what the correct result should be. The diff from the GitHub agent run is:

-args.argv[0]         is test.exe
+args.argv[0]         is D:\cppfront\cppfront

@hsutter hsutter merged commit c902f2b into hsutter:main Jan 17, 2024
@hsutter
Copy link
Owner

hsutter commented Jan 17, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants