CI: Update and fix #957
Merged
CI: Update and fix #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarzec
commented
Jan 25, 2024
| @@ -27,27 +27,27 @@ jobs: | |||
| compiler: cl.exe | |||
| steps: | |||
| - name: Checkout repo | |||
| uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
[Explanation] v3 was causing deprecation warnings from GitHub
jarzec
commented
Jan 25, 2024
| shell: cmd | ||
|
|
||
| - name: Upload patch | ||
| if: ${{ !cancelled() }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ matrix.compiler }}-patch.diff | ||
| path: regression-tests/${{ matrix.compiler }}-patch.diff | ||
| name: ${{ matrix.os }}-${{ matrix.compiler }}.patch |
There was a problem hiding this comment.
[Explanation] Adding the OS label to the patch file name will avoid issue e.g. if the same compiler is used at some stage on Ubuntu and MacOS.
|
Thanks! |
bluetarpmedia
pushed a commit
to bluetarpmedia/cppfront
that referenced
this pull request
Feb 7, 2024
* CI: Unify diffing in run-tests.shi and update workflow * CI: Update MacOs tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression-tests/run-tests.shgit diff.-lfor setting a label of the test run to be use in the name of the patch file (if it is created)..patchwhich seems to be the accepted convention..github/workflows/regression-tests.ymlworkflow file.