Skip to content

Update source paths in README #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update source paths in README #993

merged 1 commit into from
Feb 27, 2024

Conversation

danra
Copy link
Contributor

@danra danra commented Feb 22, 2024

No description provided.

@gregmarr
Copy link
Contributor

Is it needed to specify the path in the commands, or should we just say that these should be built from the source directory?

@danra
Copy link
Contributor Author

danra commented Feb 23, 2024

It's probably preferrable for the binary to be built outside of the source directory. So just specifiying the path makes sense to me. It's also less "explaining" and more "just works" than the alternative of instructing to change into the source folder.

@gregmarr
Copy link
Contributor

On the other hand, I'd hate to imply that you HAVE to build it from the root of the install if it can be built from inside the directory.

@danra
Copy link
Contributor Author

danra commented Feb 23, 2024

On the other hand, I'd hate to imply that you HAVE to build it from the root of the install if it can be built from inside the directory.

I don't think that's implied... these are instructions for first-time comers to the repo. Having it "just work" makes it just a bit easier, probably saving approx. a minute.

@hsutter
Copy link
Owner

hsutter commented Feb 27, 2024

Thanks!

@hsutter hsutter merged commit f1e2f6c into hsutter:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants