Match C++ standard used in compiler-specific run-tests scripts to the CI script #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CI script f0018d7 modified the set C++ standard for some compilers in the CI script, but did not do so for the compiler-specific run-tests scripts. This fixes the discrepancy by matching setting in the compiler-specific scripts to that of the CI script (since the above commit apparently did update the tests results according to the newly set standard in the CI script). (It would be more robust to avoid the possibility of such a discrepancy by avoiding having such settings in multiple scripts.)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f0018d7 modified the set C++ standard for some compilers in the CI script, but did not do so for the compiler-specific run-tests scripts. This fixes the discrepancy by matching setting in the compiler-specific scripts to that of the CI script (since the above commit apparently did update the tests results according to the newly set standard in the CI script).
(It would be more robust to avoid the possibility of such a discrepancy by avoiding having such settings in multiple scripts.)