Skip to content

Make changes for pip 1.5 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

gsnedders
Copy link
Member

This drops the insecure --use-mirrors, and allows Genshi to be installed insecurely. Once Travis CI upgrades, everything would fail as a result.

--use-mirrors both found mirrors and accessed them insecurely, yet
trusted them (CVE-2013-5123); pip 1.5 removes support.
Ergh. It's not like there's not been masses of warning about this.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/522

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Use the backwards compatible --allow-insecure; this will work until pip 1.7.
@gsnedders
Copy link
Member Author

Rebased onto master at 3c3dd75

@gsnedders gsnedders closed this Jan 5, 2014
@gsnedders gsnedders deleted the pip-update branch January 5, 2014 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants