Skip to content

fix: useless conditional #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 6, 2025

Error spotted by VS Code Advanced Security:

If a condition always evaluates to true or always evaluates to false, this often indicates incomplete code or a latent bug and should be examined carefully.

Recommendation
Examine the surrounding code to determine why the condition is useless. If it is no longer needed, remove it.

coliff added 2 commits June 6, 2025 12:36
Error spotted by VS Code Advanced Security:

If a condition always evaluates to true or always evaluates to false, this often indicates incomplete code or a latent bug and should be examined carefully.

Recommendation
Examine the surrounding code to determine why the condition is useless. If it is no longer needed, remove it.
@coliff coliff requested a review from thedaviddias as a code owner June 6, 2025 03:40
gemini-code-assist[bot]

This comment was marked as resolved.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95e6a13) to head (319b353).
Report is 56 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1631      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7e6e2...319b353. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coliff coliff merged commit fef603a into main Jun 6, 2025
23 of 24 checks passed
@coliff coliff deleted the dev/coliff/fix-remove-useless-conditional branch June 6, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant