Add TODO comments for unrecordable tests

jaredmoo · jaredmoo · commit 4ca0311b8ce7 · 2017-06-19T22:58:29.000-07:00
Issues Azure#4155 and Azure#4156
diff --git a/src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DatabaseBackupTests.cs b/src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DatabaseBackupTests.cs
@@ -32,13 +32,16 @@ public DatabaseBackupTests(ITestOutputHelper output) : base(output)
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestListDatabaseRestorePoints()
         {
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             RunPowerShellTest("Test-ListDatabaseRestorePoints");
         }
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRestoreGeoBackup()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-RestoreGeoBackup");
@@ -48,7 +51,8 @@ public void TestRestoreGeoBackup()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRestoreDeletedDatabaseBackup()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-RestoreDeletedDatabaseBackup");
@@ -58,7 +62,8 @@ public void TestRestoreDeletedDatabaseBackup()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRestorePointInTimeBackup()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-RestorePointInTimeBackup");
@@ -68,7 +73,8 @@ public void TestRestorePointInTimeBackup()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestServerBackupLongTermRetentionVault()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-ServerBackupLongTermRetentionVault");
@@ -78,7 +84,8 @@ public void TestServerBackupLongTermRetentionVault()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDatabaseBackupLongTermRetentionPolicy()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-DatabaseBackupLongTermRetentionPolicy");
@@ -88,7 +95,8 @@ public void TestDatabaseBackupLongTermRetentionPolicy()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestRestoreLongTermRetentionBackup()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-RestoreLongTermRetentionBackup");
@@ -98,7 +106,8 @@ public void TestRestoreLongTermRetentionBackup()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestDatabaseGeoBackupPolicy()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL backup tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4155
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-DatabaseGeoBackupPolicy");
diff --git a/src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/IndexRecommendationTests.cs b/src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/IndexRecommendationTests.cs
@@ -32,7 +32,8 @@ public IndexRecommendationTests(ITestOutputHelper output) : base(output)
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestGetIndexRecommendation()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL index recommendation tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4156
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-GetIndexRecommendations");
@@ -43,7 +44,8 @@ public void TestGetIndexRecommendation()
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestCreateIndex()
         {
-            // Test cannot be re-recorded because it has hardcoded server name
+            // TODO Rewrite SQL index recommendation tests to be recordable
+            // TODO https://github.com/Azure/azure-powershell/issues/4156
             if (TestMockSupport.RunningMocked)
             {
                 RunPowerShellTest("Test-CreateIndex");

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,16 @@ public DatabaseBackupTests(ITestOutputHelper output) : base(output)`
`32`	`32`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`33`	`33`	`public void TestListDatabaseRestorePoints()`
`34`	`34`	`{`
	`35`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`36`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`35`	`37`	`RunPowerShellTest("Test-ListDatabaseRestorePoints");`
`36`	`38`	`}`
`37`	`39`	`[Fact]`
`38`	`40`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`39`	`41`	`public void TestRestoreGeoBackup()`
`40`	`42`	`{`
`41`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`43`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`44`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`42`	`45`	`if (TestMockSupport.RunningMocked)`
`43`	`46`	`{`
`44`	`47`	`RunPowerShellTest("Test-RestoreGeoBackup");`
`@@ -48,7 +51,8 @@ public void TestRestoreGeoBackup()`
`48`	`51`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`49`	`52`	`public void TestRestoreDeletedDatabaseBackup()`
`50`	`53`	`{`
`51`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`54`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`55`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`52`	`56`	`if (TestMockSupport.RunningMocked)`
`53`	`57`	`{`
`54`	`58`	`RunPowerShellTest("Test-RestoreDeletedDatabaseBackup");`
`@@ -58,7 +62,8 @@ public void TestRestoreDeletedDatabaseBackup()`
`58`	`62`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`59`	`63`	`public void TestRestorePointInTimeBackup()`
`60`	`64`	`{`
`61`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`65`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`66`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`62`	`67`	`if (TestMockSupport.RunningMocked)`
`63`	`68`	`{`
`64`	`69`	`RunPowerShellTest("Test-RestorePointInTimeBackup");`
`@@ -68,7 +73,8 @@ public void TestRestorePointInTimeBackup()`
`68`	`73`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`69`	`74`	`public void TestServerBackupLongTermRetentionVault()`
`70`	`75`	`{`
`71`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`76`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`77`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`72`	`78`	`if (TestMockSupport.RunningMocked)`
`73`	`79`	`{`
`74`	`80`	`RunPowerShellTest("Test-ServerBackupLongTermRetentionVault");`
`@@ -78,7 +84,8 @@ public void TestServerBackupLongTermRetentionVault()`
`78`	`84`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`79`	`85`	`public void TestDatabaseBackupLongTermRetentionPolicy()`
`80`	`86`	`{`
`81`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`87`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`88`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`82`	`89`	`if (TestMockSupport.RunningMocked)`
`83`	`90`	`{`
`84`	`91`	`RunPowerShellTest("Test-DatabaseBackupLongTermRetentionPolicy");`
`@@ -88,7 +95,8 @@ public void TestDatabaseBackupLongTermRetentionPolicy()`
`88`	`95`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`89`	`96`	`public void TestRestoreLongTermRetentionBackup()`
`90`	`97`	`{`
`91`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`98`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`99`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`92`	`100`	`if (TestMockSupport.RunningMocked)`
`93`	`101`	`{`
`94`	`102`	`RunPowerShellTest("Test-RestoreLongTermRetentionBackup");`
`@@ -98,7 +106,8 @@ public void TestRestoreLongTermRetentionBackup()`
`98`	`106`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`99`	`107`	`public void TestDatabaseGeoBackupPolicy()`
`100`	`108`	`{`
`101`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`109`	`+ // TODO Rewrite SQL backup tests to be recordable`
	`110`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4155`
`102`	`111`	`if (TestMockSupport.RunningMocked)`
`103`	`112`	`{`
`104`	`113`	`RunPowerShellTest("Test-DatabaseGeoBackupPolicy");`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ public IndexRecommendationTests(ITestOutputHelper output) : base(output)`
`32`	`32`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`33`	`33`	`public void TestGetIndexRecommendation()`
`34`	`34`	`{`
`35`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`35`	`+ // TODO Rewrite SQL index recommendation tests to be recordable`
	`36`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4156`
`36`	`37`	`if (TestMockSupport.RunningMocked)`
`37`	`38`	`{`
`38`	`39`	`RunPowerShellTest("Test-GetIndexRecommendations");`
`@@ -43,7 +44,8 @@ public void TestGetIndexRecommendation()`
`43`	`44`	`[Trait(Category.AcceptanceType, Category.CheckIn)]`
`44`	`45`	`public void TestCreateIndex()`
`45`	`46`	`{`
`46`		`- // Test cannot be re-recorded because it has hardcoded server name`
	`47`	`+ // TODO Rewrite SQL index recommendation tests to be recordable`
	`48`	`+ // TODO https://github.com/Azure/azure-powershell/issues/4156`
`47`	`49`	`if (TestMockSupport.RunningMocked)`
`48`	`50`	`{`
`49`	`51`	`RunPowerShellTest("Test-CreateIndex");`