huangpf PR: dev <- Azure:dev #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Location restrictions while creating a New ApiManagement Service
## Background When attempting to run the Azure Key Vault PowerShell tests via the `RunKeyVaultTests.ps1` script, the following 5 tests would fail: ``` Test_ImportByokWithDefaultAttributes Test_ImportByokWith1024BitKey Test_ImportByokWithCustomAttributes Test_GetAllKeys Test_GetKeyVersions ``` The first 3 BYOK tests failed because they test against dummy `.byok` files that were generated with a specific subscription ID that may not match the subscription ID of whomever is running the tests. The last 2 tests failed because they attempt to reference `[Microsoft.WindowsAzure.Testing.TestUtilities]`, which cannot be found. Moreover, this PowerShell script was difficult to use if we didn't want to provide our own vault to test against for both the data plane and the control plane, but we instead wanted the script to generate its own temporary vault. Also, we sometimes would like to programmatically skip Active Directory related tests for certain environments (instead of having it hardcoded to always skip for Fairfax environments). Finally, the PowerShell script could use some cleanup with respect to formatting whitespace, fleshing out docstrings, and general organization. ## The Change This change addresses the above issues by: - Guarding the 3 BYOK tests with an if condition that tests the subscription ID. - Replacing `Wait($timeout * 1000)` with `Start-Sleep -Seconds $timeout`. - Saving/restoring temporary vault state for both the control plane and data plane tests. - Exposing the `$NoADCmdLetMode` parameter. - Generally improving the coding style.
PATCH on /tenant/access/git to enable disable Git Access is no longer required, after GIT went GA. Removing the unused cmdlet.
…ccess. Fix Example.
- Stopped skipping Test-CreateNewVault if noADCmdLetMode. - Removed PSHCommon directory and instead updated Common.ps1 from ScenarioTests.Common. - Used TestMockSupport.RunningMocked for Wait-Seconds instead.
Fix issues with running RunKeyVaultTests.ps1.
[#2306] AzureResourceManager.psd1 is included in several PS packages
PATCH /tenant/access/git is No Longer Required
* [RS Backup] Security hot fix PS changes * [RS Backup] Security fixes - added Source Resource ID support in Enable, Disable Protection and Trigger Restore cmdlets. * [RS Backup] Restore test case recordings with security fix * [RS Backup] Disabling restore test - passing in record mode, but failling in playback mode. Mostly this is some issue with the session record infra. * [RS Backup] variable spelling fix * [RS Backup] Removed dll reference and introduced RecoveryServices.Backup 0.1.1-preview * [RS Backup] Fixing line breaks * [RS Backup] Passing source resource ID in Get RP Details API * Check deployment exists before getting operations. * Update scenario test cases. * Update ChangeLog. * Fix for #2387, #2388 fix subscription and tenant validate sets when no subscriptions or tenants selected * Adding infrastructure to manage flaky check-in tests and applying to one flaky test * Removing unnecessary call to sleep during test re-execution * Update versions for hotfix release 1.5.1 * Add dates and profile change details to changelog * Fix fo9rmatting of release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.