Skip to content

huangpf PR: dev <- Azure:dev #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2016
Merged

huangpf PR: dev <- Azure:dev #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c54bcb
Make Compute test name shorter to fix on-demand build
cormacpayne Sep 21, 2016
6350005
Skip failing StaticAnalysis tests
cormacpayne Sep 21, 2016
dbaee94
Update skip message with issue number
cormacpayne Sep 21, 2016
9826270
Merge pull request #2988 from cormacpayne/demand-fix
cormacpayne Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@
<None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVirtualMachineSingleNetworkInterface.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVirtualMachineSingleNetworkInterfaceWithAcceleratedNetworking.json">
<None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestSingleNetworkInterfaceWithAcceleratedNetworking.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineNetworkInterfaceTests\TestVMNicWithAcceleratedNetworkingValidations.json">
Expand Down
2 changes: 1 addition & 1 deletion ...anager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineNetworkInterfaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void TestEffectiveRoutesAndNsg()

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestVirtualMachineSingleNetworkInterfaceWithAcceleratedNetworking()
public void TestSingleNetworkInterfaceWithAcceleratedNetworking()
{
ComputeTestController.NewInstance.RunPsTest("Test-SingleNetworkInterfaceWithAcceleratedNetworking");
}
Expand Down
0 ...rkInterfaceWithAcceleratedNetworking.json → ...rkInterfaceWithAcceleratedNetworking.json
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions tools/StaticAnalysis/StaticAnalysis.Test/SignatureVerifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public SignatureVerifierTests()
/// <summary>
///
/// </summary>
[Fact]
[Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
public void AddVerbWithoutSupportsShouldProcessParameter()
{
cmdletSignatureVerifier.Analyze(
Expand Down Expand Up @@ -68,7 +68,7 @@ public void AddVerbWithSupportsShouldProcessParameter()

#region ForceSwitch and SupportsShouldProcess

[Fact]
[Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
public void ForceParameterWithoutSupportsShouldProcess()
{
cmdletSignatureVerifier.Analyze(
Expand Down Expand Up @@ -108,7 +108,7 @@ public void ConfirmImpactWithSupportsShouldProcess()
Assert.True(testReport.ProblemIdList.Count == 0);
}

[Fact]
[Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
public void ConfirmImpactWithoutSupportsShouldProcess()
{
cmdletSignatureVerifier.Analyze(
Expand Down Expand Up @@ -136,7 +136,7 @@ public void ShouldContinueVerbWithForceSwitch()
Assert.True(testReport.ProblemIdList.Count == 0);
}

[Fact]
[Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
public void ShouldContinueVerbWithoutForceSwitch()
{
cmdletSignatureVerifier.Analyze(
Expand Down