Skip to content

Commit 028fe00

Browse files
author
Mishig
authored
[safetensors] Fix RE_SAFETENSORS_SHARD_FILE (#627)
follow up to #622 (comment) > but that was my point, the -_ is not optional > we do want to enforce some level of convention
1 parent f1c94b3 commit 028fe00

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/hub/src/lib/parse-safetensors-metadata.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ describe("parseSafetensorsMetadata", () => {
115115
const match = safetensorsFilename.match(RE_SAFETENSORS_SHARD_FILE);
116116

117117
assert.strictEqual(RE_SAFETENSORS_SHARD_FILE.test(safetensorsFilename), true);
118-
assert.strictEqual(match?.groups?.prefix, "model");
118+
assert.strictEqual(match?.groups?.prefix, "model_");
119+
assert.strictEqual(match?.groups?.basePrefix, "model");
119120
assert.strictEqual(match?.groups?.shard, "00005");
120121
assert.strictEqual(match?.groups?.total, "00072");
121122
});

packages/hub/src/lib/parse-safetensors-metadata.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ export const SAFETENSORS_INDEX_FILE = "model.safetensors.index.json";
1414
/// but in some situations safetensors weights have different filenames.
1515
export const RE_SAFETENSORS_FILE = /\.safetensors$/;
1616
export const RE_SAFETENSORS_INDEX_FILE = /\.safetensors\.index\.json$/;
17-
export const RE_SAFETENSORS_SHARD_FILE = /^(?<prefix>.*?)[_-]?(?<shard>\d{5})-of-(?<total>\d{5})\.safetensors$/;
17+
export const RE_SAFETENSORS_SHARD_FILE =
18+
/^(?<prefix>(?<basePrefix>.*?)[_-])(?<shard>\d{5})-of-(?<total>\d{5})\.safetensors$/;
1819
const PARALLEL_DOWNLOADS = 20;
1920
const MAX_HEADER_LENGTH = 25_000_000;
2021

0 commit comments

Comments
 (0)