Skip to content

Commit 4ec0384

Browse files
authored
Switch to securityFileStatus (fix failing ci) (#991)
This PR fixes the failing CI: - ~some formatting issues in `packages/tasks`~ already done in #990 - in `listFiles`, `entry.security` has been replaced by `entry.securityFileStatus` server-side. This PR updates the data structure + test to address this change. Expectation: green CI 😄
1 parent c8c982e commit 4ec0384

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/hub/src/lib/list-files.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ describe("listFiles", () => {
7575
const files: ListFileEntry[] = [];
7676

7777
for await (const entry of cursor) {
78-
delete entry.security; // flaky
78+
delete entry.securityFileStatus; // flaky
7979
files.push(entry);
8080
}
8181

packages/hub/src/lib/list-files.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface ListFileEntry {
2828
/**
2929
* Only fetched if `expand` is set to `true` in the `listFiles` call.
3030
*/
31-
security?: unknown;
31+
securityFileStatus?: unknown;
3232
}
3333

3434
/**
@@ -48,7 +48,7 @@ export async function* listFiles(
4848
*/
4949
path?: string;
5050
/**
51-
* Fetch `lastCommit` and `securityStatus` for each file.
51+
* Fetch `lastCommit` and `securityFileStatus` for each file.
5252
*/
5353
expand?: boolean;
5454
revision?: string;

packages/hub/src/types/api/api-commit.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export interface ApiLfsBatchRequest {
55
/**
66
* Optional object describing the server ref that the objects belong to. Note: Added in v2.4.
77
*
8-
* We use this object for QOL and to fail early for users when they're tring to push to the wrong reference.
8+
* We use this object for QOL and to fail early for users when they're trying to push to the wrong reference.
99
* But it does nothing for security.
1010
*/
1111
ref?: {

0 commit comments

Comments
 (0)