Skip to content

Lint fixes #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Lint fixes #990

merged 1 commit into from
Oct 29, 2024

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Oct 28, 2024

No description provided.

@pcuenca
Copy link
Member Author

pcuenca commented Oct 28, 2024

Failing in some PRs such as #986

Vaibhavs10
Vaibhavs10 reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just add a pre-commit in the repo to fix all Lint woes.

(orthogonal to the PR ofc)

@pcuenca
Copy link
Member Author

pcuenca commented Oct 29, 2024

I wonder if we should just add a pre-commit in the repo

There's already a lint check, I think we should not merge if it complains (unless in exceptional cases).

@pcuenca pcuenca merged commit c8c982e into huggingface:main Oct 29, 2024
2 of 4 checks passed
@pcuenca pcuenca deleted the lint-fixes branch October 29, 2024 09:35
@Wauplin Wauplin mentioned this pull request Oct 29, 2024
Merged
coyotte508 pushed a commit that referenced this pull request Oct 29, 2024
@Wauplin
Switch to securityFileStatus (fix failing ci) (#991)
4ec0384 
This PR fixes the failing CI:
- ~some formatting issues in `packages/tasks`~ already done in
#990
- in `listFiles`, `entry.security` has been replaced by
`entry.securityFileStatus` server-side. This PR updates the data
structure + test to address this change.

Expectation: green CI 😄
@xenova xenova mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

@julien-c julien-c julien-c approved these changes

@coyotte508 coyotte508 coyotte508 approved these changes

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcuenca @julien-c @coyotte508 @Vaibhavs10