-
Notifications
You must be signed in to change notification settings - Fork 432
Add HTRflow as a library #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTRflow as a library #1008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I left some comments to make it a bit more impactful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in a good shape. Let's wait for another review before merging. Thanks again for opening the PR! 🤗
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks @Borg93! Just a suggestion to make the code snippets better otherwise the integration looks good to me as well :)
Co-authored-by: Lucain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! CI is green so time to merge :)
This PR adds https://github.com/AI-Riksarkivet/htrflow/ as a library.