Skip to content

Add HTRflow as a library #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Add HTRflow as a library #1008

merged 15 commits into from
Nov 5, 2024

Conversation

Borg93
Copy link
Contributor

@Borg93 Borg93 commented Nov 1, 2024

@Borg93 Borg93 requested a review from ngxson as a code owner November 3, 2024 09:36
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I left some comments to make it a bit more impactful.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in a good shape. Let's wait for another review before merging. Thanks again for opening the PR! 🤗

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @Borg93! Just a suggestion to make the code snippets better otherwise the integration looks good to me as well :)

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now! CI is green so time to merge :)

@Wauplin Wauplin merged commit bc7381c into huggingface:main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants