Fix client in VLM JS inference snippet #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
gary149,
julien-c,
pcuenca and
ngxson
as code owners
mishig25
approved these changes
Nov 5, 2024
julien-c
approved these changes
Nov 5, 2024
mishig25
reviewed
Nov 5, 2024
| @@ -57,7 +57,7 @@ export const snippetTextGeneration = ( | |||
| if (streaming) { | |||
| return [ | |||
| { | |||
| client: "huggingface_hub", | |||
| client: "huggingface.js", | |||
There was a problem hiding this comment.
actually, not this? @huggingface/inference because we use like
import { HfInference } from "@huggingface/inference"
const client = new HfInference("hf_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx")There was a problem hiding this comment.
I'll let @coyotte508 decide what the best name is between huggingface.js and @huggingface/inference
There was a problem hiding this comment.
where is the huggingface.js shown?
There was a problem hiding this comment.
here: https://huggingface.co/meta-llama/Llama-3.1-8B-Instruct?inference_api=true
Go to "JavaScript". At the moment it's huggingface_hub. In this PR I changed it to huggingface.js but happy to change it to @huggingface/inference if it's better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small typo. In JS, the library should be
huggingface.jsnothuggingface_hub.