-
Notifications
You must be signed in to change notification settings - Fork 434
Update ASR task page #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ASR task page #1015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but I'd like to get @Vaibhavs10's opinion/approval
also @Vaibhavs10 should we remove sanchit-gandhi/whisper-jax from demos? this PR does that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks it looks good, yes Whisper-JAX has an issue w/ TPU's atm. Need to debug/ clear cache on demand there (which is non-trivial since we don't have full access cc: @pcuenca )
Good to merge tho 👍
btw @Deep-unlearning is Steven :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
We should. Let me take a look (next week) and I'll update the docs. |
neat gh handle Steven 😆 what's your hf handle? |
ahah thanks ! my hf handle is Steveeeeeeen, less neat tho :') |
The heart count needs to go up too :) |
Im working on it 🚀 |
No description provided.