Skip to content

Remove "words" key from DQA output #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove "words" key from DQA output #1040

merged 1 commit into from
Nov 18, 2024

Conversation

Rocketknight1
Copy link
Member

cc @Wauplin - this matches transformers because transformers never outputs a words key. I'll make another PR to transformers to remove the key from the docstrings as well.

@Rocketknight1 Rocketknight1 mentioned this pull request Nov 18, 2024
Open
@Wauplin Wauplin mentioned this pull request Nov 18, 2024
Closed
Wauplin
Wauplin approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it @Rocketknight1 !

@Wauplin Wauplin merged commit 9cb9acf into main Nov 18, 2024
5 checks passed
@Wauplin Wauplin deleted the fix-dqa-spec branch November 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rocketknight1 @Wauplin