-
Notifications
You must be signed in to change notification settings - Fork 441
DeepForest model library: Change path extensions to .safetensors and .json #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepForest model library: Change path extensions to .safetensors and .json #1144
Conversation
Hi @henrykironde can you provide more details about this PR? Has anything being changed recently in DeepForest models? Looking at the files in https://huggingface.co/models?library=deepforest, it seems that counting only |
@Wauplin thanks for the quick response. I will quote our issue for more details below, weecology/DeepForest#896 The huggingface download stats are almost certainly too low (they currently show 13 downloads in the last month of the tree model. I suspect this is due to our change from a custom download system to the built-in We submitted code to But So, I suspect this will all 'just work' if we remove the custom code from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, in that case we can just remove the count download rule - which is what we recommend libraries and apps building not the hub to do as well!
Co-authored-by: Pedro Cuenca <[email protected]>
let's get those download numbers up 😁 |
Glad to see this working, @henrykironde @ethanwhite 🚀 ![]() A couple of suggestions to improve the visitor experience, in case you have time:
I just opened a small PR to your repo to clarify that downloads are coming from Hugging Face. |
That's more like what we were expecting! Thanks! |
No description provided.