Skip to content

Update model-libraries.ts - add specification for WHAM #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

katja-hofmann
Copy link
Contributor

Configuring countDownloads for wham files with ckpt file extension

Configuring countDownloads for wham files with ckpt file extension
@katja-hofmann
Copy link
Contributor Author

Hi team,

I see that this PR is waiting on lint - does this usually take this long (about 10 hours since I submitted the PR), or is there something wrong that I can correct on my side?

image

@julien-c
Copy link
Member

@katja-hofmann i've approved to launch CI

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katja-hofmann , thanks for your PR! Changes look good to me.

I just want to highlight that by having a single repo https://huggingface.co/microsoft/wham for both 1.6B et 200M models, you won't be able to know the number of downloads for each model. What we usually recommend to do is to create 1 repo per model (so for instance microsoft/wham-1.6B and microsoft/wham-200M) and tag them with library_name: wham. This way download counts will be separated and the door will be open to add even more models on the Hub in the future (WHAM_1.6B_v2.ckpt for instance?).

Since the repo also contains code to execute the model, you can either decide to keep the code in a single repo (e.g. 1.6B repo has the code, while others are referring to the "main" one) or to move the codebase to a GH repo for instance. Depends on what would be the easiest for you (I personally like having code+weights on HF)

Let me know what you think :) This topic is slightly orthogonal to this PR but always good to handle these things at the same time.

Note: failing CI is not related to your PR.

@Wauplin
Copy link
Contributor

Wauplin commented Mar 7, 2025

@katja-hofmann related to my comment above #1215 (review), let me know what you prefer to do. Should we merge this PR as-is or wait for a split in HF repos (to benefit from more granular download analytics)

@katja-hofmann
Copy link
Contributor Author

Hi @Wauplin - thank you for your detailed comments and follow up. If you're ok with it, we'd prefer to keep the repo as is. We are not currently planning to add additional instances, and therefore prefer to keep the material in one place.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fine for me, thanks for confirming!

@Wauplin Wauplin merged commit ec7f057 into huggingface:main Mar 7, 2025
4 checks passed
@katja-hofmann katja-hofmann deleted the patch-1 branch March 7, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants