[BUGFIX] EEXIST: file already exists, symlink when file already downloaded
#1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
approved these changes
Mar 6, 2025
axel7083
reviewed
Mar 6, 2025
| @@ -100,6 +100,9 @@ export async function downloadFileToCacheDir( | |||
| await mkdir(dirname(blobPath), { recursive: true }); | |||
| await mkdir(dirname(pointerPath), { recursive: true }); | |||
There was a problem hiding this comment.
We might want to check for exists before mkdir the parent directory then, so we would avoid calling mkdir
|
Feel free to merge @frascuchon ! |
I would love to do it, but I think I don't have the right permissions 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the library in Linux environments, I have the following errors when using cached files:
This happens when trying to recreate the symbolic link. This PR checks if the symlink already exists and returns the pointer file.