[Inference providers] Root-only base URLs #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
julien-c,
hanouticelina,
SBrandeis and
coyotte508
as code owners
julien-c
approved these changes
Mar 10, 2025
SBrandeis
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/huggingface-internal/moon-landing/pull/12849 and https://github.com/huggingface-internal/moon-landing/pull/12855 (private repo). Similar PR for Python client huggingface/huggingface_hub#2918.
It is best if all base URLs for inference providers are "root-domain-only" i.e. without subpaths. This PR updates Black Forest Labs and Fireworks AI providers. Novita is taken care of in #1263.
Note that this change requires a server-side update to make things backward compatible (i.e. legacy clients using a subpath are still working). This fix is already handled server-side.