-
Notifications
You must be signed in to change notification settings - Fork 434
Add text-ranking
pipeline tag
#1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I forgot to replace these when I locally renamed the tag from `sentence-ranking` to `text-ranking`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on my side but let's wait for an approval from @merveenoyan or @pcuenca who are more used to updating the tasks files.
id: "microsoft/ms_marco", | ||
}, | ||
], | ||
demo: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the "demo" data used ? The inputs don't seem to follow the API you've described in the PR description (with query: str + passages: List[str])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no API for task-ranking
yet, nor consensus on what the spec should be. Because of this, I adopted the format from https://huggingface.co/tasks/sentence-similarity
I was under the impression that this was only used to format this box:
I can definitely remove the demo
section if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having the one you provided makes sense imo @tomaarsen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But how will it render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, I can't get moon-landing
to work anymore, not with the "Easy mode" nor with the default one. Not with Windows, not with WSL, not with Docker, not with local builds. I'll try again some other time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can make sure it works after merging (when updating the dependency in moon-landing), no worries 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot (also for adding task page!)
id: "microsoft/ms_marco", | ||
}, | ||
], | ||
demo: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having the one you provided makes sense imo @tomaarsen
id: "microsoft/ms_marco", | ||
}, | ||
], | ||
demo: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But how will it render?
-4.24 The city of Paris had a population of 2,165,423 people within its administrative city limits as of January 1, 2019 | ||
-4.32 Berlin is well known for its museums. | ||
""" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this will be faster, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the model.rank
vs model.predict
? No, the model.rank
is just a more convenient interface to the model. They're equally fast.
Hello!
Pull Request overview
text-ranking
pipeline tagsentence-similarity
Details
This PR adds a
text-ranking
pipeline tag for reranker models like:E.g.:
I haven't created a spec for the API here, as I think that's better left to those who've created other specs. I think we might already have a Sentence Ranking API that we might not want to break.
This is slightly blocking the next Sentence Transformers release, as I'd like to know whether I can tag CrossEncoder (a.k.a. reranker) models as
text-ranking
.Related to this PR: https://github.com/huggingface-internal/moon-landing/pull/12877 (private repo).