Skip to content

fix: better handling of symlink (Windows,...) #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 17, 2025

Conversation

jeffmaury
Copy link
Contributor

Add finer handling of symlink as it is not supported on Windows.

Fixes #1268

@jeffmaury jeffmaury requested a review from coyotte508 as a code owner March 12, 2025 14:46
@coyotte508
Copy link
Member

Thanks for the contribution!

cc @Wauplin @hanouticelina for viz since it's also in the python implem

@coyotte508 coyotte508 self-assigned this Mar 13, 2025
Signed-off-by: Jeff MAURY <[email protected]>
Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I think we may still want to use relative paths (from what is said in the doc comment) on windows in the symlink, but current version is already an improvement to make it work better in windows.

Approving and will merge in a few days

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we may still want to use relative paths

Agree on that. Absolute paths have caused quite some trouble when I introduced them (and only for a short period of time)

@coyotte508 coyotte508 merged commit 0b13731 into huggingface:main Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub snapshot_download not compatible with Windows
4 participants