-
Notifications
You must be signed in to change notification settings - Fork 434
fix: better handling of symlink (Windows,...) #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes huggingface#1268 Signed-off-by: Jeff MAURY <[email protected]>
Thanks for the contribution! cc @Wauplin @hanouticelina for viz since it's also in the python implem |
Signed-off-by: Jeff MAURY <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I think we may still want to use relative paths (from what is said in the doc comment) on windows in the symlink, but current version is already an improvement to make it work better in windows.
Approving and will merge in a few days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think we may still want to use relative paths
Agree on that. Absolute paths have caused quite some trouble when I introduced them (and only for a short period of time)
Add finer handling of symlink as it is not supported on Windows.
Fixes #1268