fix: createSymlink deletes the wrong file #1307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes huggingface#1306 Signed-off-by: Jeff MAURY <[email protected]>
coyotte508
added a commit
that referenced
this pull request
Mar 22, 2025
Alternative to #1307 Fix #1306 I was just too confused by the src/dst params, nodej's official docs could be clearer too. Now the params are explictly named and there is a real test to check the filesystem contents. By the way, it's a `copy` operation not a `rename` (because it was already the case, the `new_blob` param was never passed) Also took the opportunty to use relative symlinks cc @Wauplin for better windows support cc @jeffmaury @axel7083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1306