[Inference Providers] Refactor: better typing? #1332
Conversation
|
much better in terms of typing, thank you! one question: It seems to me (and i might be wrong) the improved typing for |
| @@ -73,7 +74,36 @@ export abstract class TaskProviderHelper { | |||
| abstract preparePayload(params: BodyParams): unknown; | |||
| } | |||
|
|
|||
| export class BaseConversationalTask extends TaskProviderHelper { | |||
| export interface TextToImageTaskHelper { | |||
| getResponse(response: unknown, | |||
There was a problem hiding this comment.
when making response as unknown here, is it still possible to declare the getResponse method in BlackForestLabsTextToImageTask with response: BlackForestLabsResponse ?
same for other downstream classes that will implement TextToImageTaskHelper.
There was a problem hiding this comment.
got my answer: it should be good 😄 i was just overthinking it
This PR introduces task helpers to achieve better typing of the `getProviderHelper`, this is inspired by @SBrandeis demonstration PR #1332, without reversing the mapping. There is a lot of diff (sorry for that) because I isolated every HF inference API-specific code into the provider file and there are a lot of supported tasks 😬 --------- Co-authored-by: SBrandeis <[email protected]>
cc @hanouticelina
For demonstration purpose only - let's not merge
I think we can achieve better typing of the
getProviderHelperif we reverse the mapping (provider -> tasktotask -> provider)See the textToImage file (no more type casts)
Having to implement and extend 2 types when implementing a helper is quite inconvenient on the other hand - so not sure about this either