Skip to content

Fix linting in @huggingface/inference (remove unused vars) #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Apr 10, 2025

Fixes failing lint CI:

packages/inference lint:check: /home/runner/work/huggingface.js/huggingface.js/packages/inference/src/tasks/nlp/tokenClassification.ts
packages/inference lint:check:   5:10  error  'toArray' is defined but never used  @typescript-eslint/no-unused-vars
packages/inference lint:check: /home/runner/work/huggingface.js/huggingface.js/packages/inference/src/tasks/nlp/zeroShotClassification.ts
packages/inference lint:check:   5:10  error  'toArray' is defined but never used  @typescript-eslint/no-unused-vars
packages/inference lint:check: ✖ 2 problems (2 errors, 0 warnings)
packages/inference lint:check: Failed

From #1315 (cc @hanouticelina for viz). Strange that in that PR, the CI didn't catch it (the last commit was marked as ✅). May need to investigate (cc @coyotte508)

Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! indeed, it's weird the CI was ✅

@xenova xenova merged commit 0cbd641 into main Apr 10, 2025
5 checks passed
@xenova xenova deleted the fix-linting branch April 10, 2025 18:29
@xenova
Copy link
Contributor Author

xenova commented Apr 10, 2025

All good! Thanks for the speedy review! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants