Add support for KerasNLP library #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
osanseviero,
SBrandeis,
gary149 and
julien-c
as code owners
julien-c
reviewed
Apr 10, 2024
There was a problem hiding this comment.
on the linked repo you use keras_nlp (with an underscore) as a tag, here you use a dash, which is it?
|
preference for the dash on my side, would be more consistent with other libraries and look nicer |
|
Preference for the dash as well |
julien-c
approved these changes
Apr 11, 2024
|
Thanks for fixing the CI @coyotte508! |
Wauplin
added a commit
that referenced
this pull request
Apr 17, 2024
In #616 we added basic support for the `keras-nlp` library. This PR adds a code snippet for KerasNLP models. I just got confirmation from @mattdangerw that models can be loaded with: ```py import keras_nlp tokenizer = keras_nlp.models.Tokenizer.from_preset("hf://${model.id}") backbone = keras_nlp.models.Backbone.from_preset("hf://${model.id}") ``` We might want to do more fancy stuff in the future to parse the underlying model architecture server-side but in the meantime this is a valid solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent work to integrate KerasNLP library with the Hub, let's add it in our libraries list. KerasNLP is based on Keras3 but for now let's focus on the KerasNLP side of things (we also have on-going work for Keras but that's orthogonal).
This PR will add a pretty name for "KerasNLP" tag + add urls to official docs and github repo.
We will be able to generate code snippet in the future as well but it should be clarified first. I suggest that we merge this PR "as-is" and add support for code snippets later when it's ready.
About download counts, KerasNLP uses a
config.jsonfile so it should already count correctly.Bonus: first KerasNLP models on the Hub? https://huggingface.co/google/gemma-2b-it-keras/discussions/2. Model can be loaded with:
🎉