Skip to content

[gguf & st] parse shard filenames in typed function #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Apr 17, 2024

follow up to #627 (review)

why not a typed function fn(filename) that returns all the data in a typed manner instead of the regex 🙈 .
Currently in the next version of HF.js we can change the regex to something else, removing or renaming the groups, and on moon's side we'd have no clue. No compiler warning or anything.

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mishig25 mishig25 merged commit c0a43bc into main Apr 17, 2024
@mishig25 mishig25 deleted the shard_file_parse_fns branch April 17, 2024 08:50
@julien-c
Copy link
Member

in most cases it's useful to wait a little more than 10 mins before merging 🥲

(LGTM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants