-
Notifications
You must be signed in to change notification settings - Fork 430
Add support for EDS-NLP library #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83ac7cc
to
732cd1f
Compare
Hi @percevalw! Nice to see you in a Github PR! 🤗 There are actually several definitions to "add support for xxx library" on the Hub, which correspond to your 2 PRs:
Note that regardless of these integrations, it is already possible to upload your models to the Hub, adapt your library to upload to/download from the Hub, adapt your library to tag the uploaded models, enable download counts with a config.json file, etc. |
About this PR itself (and the dummy NER repo), do you think it'll be possible to move the Those are only recommendations, nothing wrong per-se with the current structure. |
732cd1f
to
1bc8319
Compare
Thank you for the thorough review!
This structure makes it easier for us to install the model but indeed also makes it more difficult to download the files in a standardised way. I'll try to look into this again.
Fair enough, I'll close the other PR and check back when we're amongst the big ones :) |
1bc8319
to
6f43bb1
Compare
6f43bb1
to
25f3c74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on it @percevalw! Looks good to me now :) I left a minor comment as you can provide a documentation url as well.
Co-authored-by: Lucain <[email protected]>
Thank you! The suggestion to move the artifacts folder to the root of the repo was very relevant, and I was able to proceed in that direction. That being said, adding the library to huggingface.js should not be impacted by the architecture of the models. In particular, it should not affect the download count (tracked by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to know! If it ever change in the future, you can always come back for a second PR in huggingface.js anyway. But agree with you that wildcard: { path: "*/config.cfg" },
will work in any case (EDIT: except if config.cfg
is moved at the root of the repo at some point)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Omar Sanseviero <[email protected]>
Merged! :) |
very cool – let's make sure future models like https://huggingface.co/AP-HP/eds-pseudo-public are as visible as possible 🔥 |
Hi,
This PR adds support for the edsnlp library (related to huggingface/api-inference-community#424), an NLP library developed at the Greater Paris University Hospitals (AP-HP) with a specific focus on hybrid models (rule-based + ML) and multi-tasking, widely used in the structuring of clinical language at scale (NER, entity linking, document classification, event extraction, ...).
I saw that the file https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/library-to-tasks.ts was automatically generated from a GitHub CI as mentioned on the docs, but didn't see how the action would edit it so I took the liberty of modifying it myself.
Let me know if you need more information or if I need to change anything about this PR, thanks !