-
Notifications
You must be signed in to change notification settings - Fork 443
Added NVIDIA V100 GPUs #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Given its computational power it should probably be ordered above or below the A100 family cc @pcuenca ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! We are using FP16 as the reference for tflops. In terms of placement, I think it makes sense to keep it after the Titan as it's less powerful and belongs to a previous generation.
Co-authored-by: Pedro Cuenca <[email protected]>
Applied suggested changes. Please approve. |
Looks like the format check failed, though not sure for which line https://github.com/huggingface/huggingface.js/actions/runs/9208329481/job/25330626278?pr=706 |
Thanks @coyotte508 for the fix, sorry I missed on review :) |
Nothing to worry, I improved the CI to show the diff (maybe we could even add a bot that listens to @Format comments :)) |
i think we should aim to order chronologically, WDYT? |
yes, chronological family order sounds great, I can address it in a PR tomorrow |
Merging in the mean time :) |
why not put it in the right place in this PR @coyotte508? |
It's at its correct place, it was released in 2017 and the RTX titan above was released in 2018. |
Ah cool, thanks |
Added NVIDIA V100 GPUs