Skip to content

Added NVIDIA V100 GPUs #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2024
Merged

Added NVIDIA V100 GPUs #706

merged 5 commits into from
May 24, 2024

Conversation

nahidalam
Copy link
Contributor

Added NVIDIA V100 GPUs

@coyotte508
Copy link
Member

Given its computational power it should probably be ordered above or below the A100 family cc @pcuenca ?

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! We are using FP16 as the reference for tflops. In terms of placement, I think it makes sense to keep it after the Titan as it's less powerful and belongs to a previous generation.

@nahidalam
Copy link
Contributor Author

Applied suggested changes. Please approve.

@nahidalam
Copy link
Contributor Author

Looks like the format check failed, though not sure for which line https://github.com/huggingface/huggingface.js/actions/runs/9208329481/job/25330626278?pr=706

@pcuenca
Copy link
Member

pcuenca commented May 23, 2024

Thanks @coyotte508 for the fix, sorry I missed on review :)

@coyotte508
Copy link
Member

Thanks @coyotte508 for the fix, sorry I missed on review :)

Nothing to worry, I improved the CI to show the diff

(maybe we could even add a bot that listens to @Format comments :))

@julien-c
Copy link
Member

Given its computational power it should probably be ordered above or below the A100 family cc @pcuenca ?

i think we should aim to order chronologically, WDYT?

@pcuenca
Copy link
Member

pcuenca commented May 23, 2024

order chronologically

yes, chronological family order sounds great, I can address it in a PR tomorrow

@coyotte508
Copy link
Member

order chronologically

yes, chronological family order sounds great, I can address it in a PR tomorrow

Merging in the mean time :)

@coyotte508 coyotte508 merged commit 8fe92c7 into huggingface:main May 24, 2024
4 checks passed
@julien-c
Copy link
Member

why not put it in the right place in this PR @coyotte508?

@coyotte508
Copy link
Member

why not put it in the right place in this PR @coyotte508?

It's at its correct place, it was released in 2017 and the RTX titan above was released in 2018.

@julien-c
Copy link
Member

Ah cool, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants