added rtx 3050 mobile and also added 6GB to DEFAULT_MEMORY_OPTIONS #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Om-Alve
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin and
julien-c
as code owners
|
Thank you for the PR! The |
Ah, I'm sorry I thought that they were the default values for VRAM, should I undo that change in this PR? |
pcuenca
approved these changes
May 23, 2024
packages/tasks/src/hardware.ts
Outdated
Comment on lines
132
to
133
| tflops: 7.639, | ||
| memory:[6], |
There was a problem hiding this comment.
The first version was slower and had 4 GB: https://www.techpowerup.com/gpu-specs/geforce-rtx-3050-mobile.c3788
Let's keep this one for now (Numbers match this reference: https://www.techpowerup.com/gpu-specs/geforce-rtx-3050-mobile-refresh-6-gb.c3971)
pcuenca
reviewed
May 23, 2024
pcuenca
reviewed
May 23, 2024
pcuenca
reviewed
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info about RTX 3050 mobile 6GB and also added 6GB to the DEFAULT_MEMORY_OPTIONS list