Update hardware.ts #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pcuenca merged 8 commits into huggingface:main from walmartbaggg:patch-1

May 30, 2024

Contributor

walmartbaggg commented May 28, 2024

add some unique gpus


          Update hardware.ts

1e44efc

add some unique gpus

walmartbaggg requested review from osanseviero, SBrandeis, gary149, Wauplin, julien-c and pcuenca as code owners

May 28, 2024 18:27


          Update hardware.ts

66d40b3

walmartbaggg commented

View reviewed changes

Contributor Author

walmartbaggg left a comment

fixed syntax


          more gpus

0dd81d0

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved


          Merge branch 'main' into patch-1

c5dee05

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca reviewed

View reviewed changes

packages/tasks/src/hardware.ts Outdated Show resolved Hide resolved

pcuenca added 4 commits

May 30, 2024 10:02


          Apply suggestions from code review

c7dbc85


          Reorder a few cards

73c87ce


          Add brace

f9b533c


          lint

36a8759

Member

pcuenca commented May 30, 2024 •

edited

Loading

I reordered some entries and used float32 performance for cards that don't support float16 natively, on the thought that nobody would use them in float16. Waiting for other maintainers to comment on whether this is ok or we should just skip those older cards.

Some people do use P4s they have around: https://www.reddit.com/r/homelab/comments/1aiuqnr/worth_to_get_a_tesla_p4/

Member

julien-c commented May 30, 2024

lgtm!

coyotte508 approved these changes

View reviewed changes

pcuenca merged commit d54d39f into huggingface:main

4 checks passed

Member

pcuenca commented May 30, 2024

Thanks a lot @m626zNq!

walmartbaggg deleted the patch-1 branch

May 30, 2024 13:37

Contributor Author

walmartbaggg commented May 30, 2024

Thanks a lot @m626zNq!

Yw! Thank you for reviewing and editing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pcuenca pcuenca left review comments

coyotte508 coyotte508 approved these changes

osanseviero Awaiting requested review from osanseviero

SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

gary149 Awaiting requested review from gary149 gary149 is a code owner

Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

julien-c Awaiting requested review from julien-c julien-c is a code owner

Labels

None yet