Add TiC-CLIP #750
Merged
Add TiC-CLIP #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merveenoyan
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Co-authored-by: Omar Sanseviero <[email protected]>
Co-authored-by: Omar Sanseviero <[email protected]>
Co-authored-by: Omar Sanseviero <[email protected]>
Wauplin
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
LGTM :)
To make it work, all models from https://huggingface.co/collections/apple/tic-clip-666097407ed2edff959276e0 must have library_name: tic-clip in their modelcard metadata. While you are at it, can you also explicitly set pipeline_tag: zero-shot-image-classification instead of having it as tags? (already works well with moon-landing but better to be explicit)
osanseviero
approved these changes
Jun 11, 2024
|
@Wauplin I can open PR to all once this is merged IMO (or should I do it before?) |
|
It can be done in parallel - there's nothing blocking on either side. In general having proper metadata on the model cards, even if download stats are not enabled yet, would be good to have the correct library set up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @osanseviero @pcuenca as discussed
added it to have the model counts rather than having it as a library