👾Fix chunk count not incrementing when parsing additional chunks in a local file

[ryan-the-crayon]

When parsing a local GGUF and the metadata section does not fit in the same chunk, the parser would try to load more chunks. However, in the local file implementation range view, the chunk count is not incremented, resulting it not actually loading in more data.

[mishig25]

cc: @ngxson

[ngxson]

LGTM. Thanks! I don't understand why I missed this line of code 👀

[mishig25]

@ryan-the-crayon thanks a lot for the contribution! Anyway, you can add a test case ?

huggingface.js/packages/gguf/src/gguf.spec.ts

Lines 230 to 241 in e2689f8

	it("should parse a local file", async () => {
	// download the file and save to .cache folder
	if (!fs.existsSync(".cache")) {
	fs.mkdirSync(".cache");
	}
	const res = await fetch(URL_V1);
	const arrayBuf = await res.arrayBuffer();
	fs.writeFileSync(".cache/model.gguf", Buffer.from(arrayBuf));
	const { metadata } = await gguf(".cache/model.gguf", { allowLocalFile: true });
	expect(metadata).toMatchObject({ "general.name": "tinyllamas-stories-260k" });
	});

[ngxson]

FYI, I made a gguf with 32MB of metadata (metadata usually takes less than 2MB): https://huggingface.co/ngxson/test_gguf_models/blob/main/gguf_test_big_metadata.gguf

The test would be:

const parsedGguf = await gguf(".cache/model.gguf", { allowLocalFile: true });
const { metadata } = (parsedGguf as GGUFParseOutput<{ strict: false }>); // custom metadata arch, no need for typing
expect(metadata['dummy.1']).toBeDefined(); // first metadata in the list
expect(metadata['dummy.32767']).toBeDefined(); // last metadata in the list

CPP code to generate gguf

#include "ggml.h"
#include <cstring>
#include <string>

int main(int argc, char ** argv) {
    struct gguf_context * ctx = gguf_init_empty();
    gguf_set_val_str(ctx, "general.architecture", "gguf_test_big_metadata");

    char str1kb[1025];
    std::memset(str1kb, 'A', 1024);
    str1kb[1024] = '\0';
    for (int i = 0; i < 32 * 1024; i++) {
        gguf_set_val_str(ctx, ("dummy." + std::to_string(i)).c_str(), str1kb);
    }

    gguf_write_to_file(ctx, "gguf_test_big_metadata.gguf", false);
    gguf_free(ctx);
}

[mishig25]

@ryan-the-crayon @ngxson merged and the new version of @huggingface/gguf.js with the fix is released