-
Notifications
You must be signed in to change notification settings - Fork 431
Add YOLOv10 as library #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -650,6 +650,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
docsUrl: "https://github.com/jasonppy/VoiceCraft", | |||
snippets: snippets.voicecraft, | |||
}, | |||
yolov10: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Note that this might impact few dozen repos https://huggingface.co/models?other=yolov10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also impacts quants/ conversions as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
yolov10: { | ||
prettyLabel: "YOLOv10", | ||
repoName: "yolov10", | ||
repoUrl: "https://github.com/THU-MIG/yolov10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit confusing for my brain as they install from yolov10
GH repo and then use ultralytics
for inference: https://github.com/ultralytics/ultralytics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes would make more sense to link to https://github.com/ultralytics/ultralytics no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but the code base includes several updates to work directly with the hub.
The Ultralytics repo doesn't support that :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @glenn-jocher wdyt? would be awesome to properly link to Ultralytics implem from model pages on the Hub!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference the PR is here ultralytics/ultralytics#13294
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julien-c @NielsRogge hi guys, could we set up a call to understand this a little better? https://calendly.com/glenn-jocher/meet
Thanks!
@@ -650,6 +650,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
docsUrl: "https://github.com/jasonppy/VoiceCraft", | |||
snippets: snippets.voicecraft, | |||
}, | |||
yolov10: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also impacts quants/ conversions as well.
The YOLOv10 author already added
library_name: yolov10
into each of his model repos, e.g. https://huggingface.co/jameslahm/yolov10x.This PR adds a "How to use this model" button along with a code snippet.
cc @jameslahm