[Fix] type ModelData.instance_prompt #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
pcuenca
reviewed
Sep 20, 2024
| @@ -107,7 +107,7 @@ export interface ModelData { | |||
| parameters?: Record<string, unknown>; | |||
| }; | |||
| base_model?: string | string[]; | |||
| instance_prompt?: string; | |||
| instance_prompt?: string | null; | |||
There was a problem hiding this comment.
Interesting, I would have thought that the trailing ? would imply that.
There was a problem hiding this comment.
instance_prompt?: string is string | undefined
instance_prompt?: string | null is string | null | undefined
in the strictest sense null !== undefined
There was a problem hiding this comment.
ok when can it be set to null?
There was a problem hiding this comment.
I'm not sure when but that is how it was defined in moon:
instance_prompt?: string | null;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #909