Skip to content

[Tasks] Fix small typos in generation params definitions #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

[Tasks] Fix small typos in generation params definitions #924

merged 2 commits into from
Sep 23, 2024

Conversation

hanouticelina
Copy link
Contributor

This PR fixes small typos in the descriptions of max_new_tokens and min_new_tokens generation params.

@hanouticelina hanouticelina added the tasks @huggingface/tasks related label Sep 23, 2024
Wauplin
Wauplin reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this!

Can you re-generate the .js parts based on your changes? You have to

  • cd packages/tasks
  • pnpm install
  • pnpm run inference-codegen
  • commit the updated files

Thanks!

Wauplin
Wauplin approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hanouticelina hanouticelina merged commit 5a92211 into main Sep 23, 2024
5 checks passed
@hanouticelina hanouticelina deleted the fix-typo-in-parameters-definitions branch September 23, 2024 16:36
@Wauplin Wauplin mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

Assignees
No one assigned
Labels
tasks @huggingface/tasks related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanouticelina @Wauplin