[Inference snippets] VLM hf_hub, oai snippets #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Wauplin
approved these changes
Oct 25, 2024
Comment on lines
+20
to
+35
| model.pipeline_tag === "text-generation" | ||
| ? [{ role: "user", content: "What is the capital of France?" }] | ||
| : [ | ||
| { | ||
| role: "user", | ||
| content: [ | ||
| { | ||
| type: "image_url", | ||
| image_url: { | ||
| url: "https://cdn.britannica.com/61/93061-050-99147DCE/Statue-of-Liberty-Island-New-York-Bay.jpg", | ||
| }, | ||
| }, | ||
| { type: "text", text: "Describe this image in one sentence." }, | ||
| ], | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Feels like these example messages should be in inputs.ts. I can do it in a later PR if you want.
mishig25
added a commit
that referenced
this pull request
Oct 29, 2024
Refactor conversational input to getModelInputSnippet. Follow up to comment #985 (comment) @Wauplin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #976, now we can show
hf_hub,oaisnippets for VLMs ("conversational image-text-to-text" models).