Skip to content

Switch to securityFileStatus (fix failing ci) #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Switch to securityFileStatus (fix failing ci) #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0754dcb
fix formatting
Wauplin Oct 29, 2024
4e38ac2
support securityFileStatus and fix test
Wauplin Oct 29, 2024
e3183da
Merge branch 'main' into fix-failing-ci
Wauplin Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/hub/src/lib/list-files.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe("listFiles", () => {
const files: ListFileEntry[] = [];

for await (const entry of cursor) {
delete entry.security; // flaky
delete entry.securityFileStatus; // flaky
files.push(entry);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/hub/src/lib/list-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export interface ListFileEntry {
/**
* Only fetched if `expand` is set to `true` in the `listFiles` call.
*/
security?: unknown;
securityFileStatus?: unknown;
}

/**
Expand All @@ -48,7 +48,7 @@ export async function* listFiles(
*/
path?: string;
/**
* Fetch `lastCommit` and `securityStatus` for each file.
* Fetch `lastCommit` and `securityFileStatus` for each file.
*/
expand?: boolean;
revision?: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/hub/src/types/api/api-commit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export interface ApiLfsBatchRequest {
/**
* Optional object describing the server ref that the objects belong to. Note: Added in v2.4.
*
* We use this object for QOL and to fail early for users when they're tring to push to the wrong reference.
* We use this object for QOL and to fail early for users when they're trying to push to the wrong reference.
* But it does nothing for security.
*/
ref?: {
Expand Down
Loading