Add optional CORS allow any option value in http server cli #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, When i specify * value in --cors-allow-origin i am still facing cors error in browser can you please help me with this |
MasakiMu319
pushed a commit
to MasakiMu319/text-embeddings-inference
that referenced
this pull request
Nov 27, 2024
aagnone3
pushed a commit
to StratisLLC/hf-text-embeddings-inference
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds option value '*' to --cors-allow-origin cli option to allow browser-based apps to use the embedding server directly. This is useful for local deployments of the embeddings inference server.