feat: conditionally toggle chat on invocations route #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
reviewed
Jan 18, 2024
Narsil
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM.
I just think we should document the behavior somewhere.
@philschmid any idea of where that will be best documented for SM users ?
Good question. Should add a dedicated documentation page in TGI on how to deploy to sagemaker? Where we then can include this? |
|
I'm fine with it @drbh Could you create a new page in the doc ? This can be done in a follow-up PR. |
Happy to help here! It would mostly base on this blog posts: |
kdamaszk
pushed a commit
to kdamaszk/tgi-gaudi
that referenced
this pull request
Apr 29, 2024
This PR adds support for reading the `OAI_ENABLED` env var which will
changes the function called when the `/invocations` is called.
If `OAI_ENABLED=true` the `chat_completions` method is used otherwise it
defaults to `compat_generate`.
example running the router
```bash
OAI_ENABLED=true \
cargo run -- \
--tokenizer-name mistralai/Mistral-7B-Instruct-v0.2
```
example request
```bash
curl localhost:3000/invocations \
-X POST \
-d '{ "model": "tgi", "messages": [ { "role": "user", "content": "What is the IP address of the Google DNS servers?" } ], "stream": false, "max_tokens": 20, "logprobs": true, "seed": 0 }' \
-H 'Content-Type: application/json' | jq
```
**please let me know if any naming changes are needed or if any other
routes need similar functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading the
OAI_ENABLEDenv var which will changes the function called when the/invocationsis called.If
OAI_ENABLED=truethechat_completionsmethod is used otherwise it defaults tocompat_generate.example running the router
example request
curl localhost:3000/invocations \ -X POST \ -d '{ "model": "tgi", "messages": [ { "role": "user", "content": "What is the IP address of the Google DNS servers?" } ], "stream": false, "max_tokens": 20, "logprobs": true, "seed": 0 }' \ -H 'Content-Type: application/json' | jq**please let me know if any naming changes are needed or if any other routes need similar functionality.