Skip to content

fix: read stderr in download #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: read stderr in download #1486

merged 2 commits into from
Jan 25, 2024

Conversation

OlivierDehaene
Copy link
Contributor

@OlivierDehaene OlivierDehaene commented Jan 25, 2024 •
edited
Loading

@OlivierDehaene OlivierDehaene mentioned this pull request Jan 25, 2024
Closed
4 tasks
@mssalvatore
Copy link

mssalvatore commented Jan 25, 2024 •
edited
Loading

@OlivierDehaene Perhaps we should also add a change that sets the HF_HUB_DISABLE_PROGRESS_BARS=1 environment variable for the container.

@OlivierDehaene OlivierDehaene merged commit 9c320e2 into main Jan 25, 2024
@OlivierDehaene OlivierDehaene deleted the fix/download_hang branch January 25, 2024 17:16
@OlivierDehaene OlivierDehaene mentioned this pull request Jan 26, 2024
Closed
4 tasks
helena-intel pushed a commit to helena-intel/text-generation-inference-hf that referenced this pull request Feb 1, 2024
@OlivierDehaene @helena-intel
fix: read stderr in download (huggingface#1486)
fc5bbde 
huggingface#1186
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Apr 29, 2024
@OlivierDehaene @kdamaszk
fix: read stderr in download (huggingface#1486)
ac0be8a 
huggingface#1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierDehaene @mssalvatore