Skip to content

feat: Qwen2 #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat: Qwen2 #1608

merged 2 commits into from
Feb 28, 2024

Conversation

OlivierDehaene
Copy link
Contributor

See #1584

@OlivierDehaene
Copy link
Contributor Author

Kudos @Jason-CKY!
I just added the speculative head for medusa support and changed the integration test to use a smaller model.

@OlivierDehaene OlivierDehaene changed the title feat: Qwen feat: Qwen2 Feb 28, 2024
@OlivierDehaene OlivierDehaene merged commit 26cdea5 into main Feb 28, 2024
@OlivierDehaene OlivierDehaene deleted the feat/qwen branch February 28, 2024 14:50
@paulcx
Copy link

paulcx commented Feb 29, 2024

@OlivierDehaene errors exsited in fastapi docs front page (sha-e6bb3ff)

Errors
Hide
 
Resolver error at paths./v1/chat/completions.post.requestBody.content.application/json.schema.properties.tool_choice.allOf.0.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/ToolType does not exist in document
Resolver error at paths./v1/chat/completions.post.requestBody.content.application/json.schema.properties.tools.items.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/Tool does not exist in document
Resolver error at paths./v1/chat/completions.post.requestBody.content.application/json.schema.properties.messages.items.properties.tool_calls.allOf.0.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/ToolCall does not exist in document
Resolver error at paths./v1/chat/completions.post.responses.200.content.application/json.schema.properties.choices.items.properties.delta.properties.tool_calls.allOf.0.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/DeltaToolCall does not exist in document
Resolver error at paths./v1/chat/completions.post.requestBody.content.application/json.schema.properties.messages.items.properties.tool_calls.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/ToolCall does not exist in document
Resolver error at paths./v1/chat/completions.post.requestBody.content.application/json.schema.properties.tool_choice.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/ToolType does not exist in document
Resolver error at paths./v1/chat/completions.post.responses.200.content.application/json.schema.properties.choices.items.properties.delta.properties.tool_calls.$ref
Could not resolve reference: Could not resolve pointer: /components/schemas/DeltaToolCall does not exist in document

I also found that the results of model reasoning are completely garbled, as if there are some problems. The same model uses vllm reasoning to answer correctly.

@OlivierDehaene
Copy link
Contributor Author

I'm sorry I don't understand what you are talking about.

@paulcx
Copy link

paulcx commented Mar 1, 2024

The errors I pasted above is from web page of TGI api docs. I guess it is related to openapi schema?

kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Apr 29, 2024
See huggingface#1584

---------

Co-authored-by: Cheng Kuan Yong Jason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants