Dev/mask ldconfig output v2 #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53c2c3d.
run ldconfig before launching tgi Signed-off-by: Raphael Glon <[email protected]>
Narsil
reviewed
Apr 8, 2024
XciD
reviewed
Apr 8, 2024
| @@ -0,0 +1,5 @@ | |||
| #!/bin/bash | |||
|
|
|||
| ldconfig 2>/dev/null || echo 'unable to refresh ld cache, not a big deal in most cases' | |||
There was a problem hiding this comment.
will still be displayed to user no?
There was a problem hiding this comment.
the echo message will, the error message won't.
4 tasks
kdamaszk
pushed a commit
to kdamaszk/tgi-gaudi
that referenced
this pull request
Apr 29, 2024
wrap text-generation-launcher in docker image mask ldconfig failures to user (no need in most cases anyway) --------- Signed-off-by: Raphael Glon <[email protected]> Co-authored-by: Raphael Glon <[email protected]>
4 tasks
Nilabhra
pushed a commit
to TII-AI-Research-Center/text-generation-inference
that referenced
this pull request
May 14, 2024
wrap text-generation-launcher in docker image mask ldconfig failures to user (no need in most cases anyway) --------- Signed-off-by: Raphael Glon <[email protected]> Co-authored-by: Raphael Glon <[email protected]>
kdamaszk
added a commit
to kdamaszk/tgi-gaudi
that referenced
this pull request
May 16, 2024
This reverts commit 194fcb4.
regisss
pushed a commit
to huggingface/tgi-gaudi
that referenced
this pull request
May 21, 2024
Co-authored-by: Karol Damaszke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap text-generation-launcher in docker image
mask ldconfig failures to user (no need in most cases anyway)