Fixing some legacy behavior (big swapout of serverless on legacy stuff). #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
reviewed
May 23, 2024
| VLM_BATCH_TYPES = {PaliGemmaBatch, VlmCausalLMBatch, IdeficsCausalLMBatch} | ||
| except (ImportError, NotImplementedError): | ||
| # These imports can fail on CPU/Non flash. | ||
| VLM_BATCH_TYPES = set() |
There was a problem hiding this comment.
Do imports always all fail, or is it worth trying each import separately?
There was a problem hiding this comment.
They alll have the same root cause on CPU which is flash missing on CPU and the NotImplementedError is because for some reason the resolution order is weird and we end up in a strong assert statement (within flash module) instead of a simple ImportError.
They should never fail on flash enabled (and all these models can only work with flash).
Co-authored-by: Daniël de Kok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.