Skip to content

Fixing GPTQ imports. #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2024
Merged

Fixing GPTQ imports. #1994

merged 3 commits into from
Jun 3, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Jun 3, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil
Fixing indirect GPTQ loads.
9a9b679 
Loading GPTQ (or any kernel) should always be lazy.
Some platforms don't have GPTQ support and shouldn't fail because of
imports.
@Narsil Narsil mentioned this pull request Jun 3, 2024
Merged
5 tasks
danieldk
danieldk reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the module-level exception.

server/text_generation_server/layers/gptq/__init__.py Outdated
Comment on lines 9 to 10
raise RuntimeError("No")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing leftover?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

Narsil
Narsil commented Jun 3, 2024
View reviewed changes
Narsil
Narsil commented Jun 3, 2024
View reviewed changes
@Narsil Narsil merged commit 9add5d0 into main Jun 3, 2024
3 checks passed
@Narsil Narsil deleted the fix_indirect_gptq_load branch June 3, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Narsil @danieldk