-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ROCm and sliding windows fixes #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
context --max-total-tokens, right ? (We need to crash at load time, crashing randomly at runtime is a terrible UX). |
@Narsil I assume paged attention always works with sliding window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix models requiring window attention - no need to raise an error at load time in case max_input_tokens < sliding_window.
Also, updates vllm fork commit to use the fixes from ROCm/vllm#28 & fix a few rocm issues